Issue #3678 - WebSocket rename for jetty-10 #4441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
…3678-WebSocketRename
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
approved these changes
Dec 23, 2019
There was a problem hiding this comment.
This looks good.... but should we also rename all the JavaxWebsocketSomething classes to WebsocketJavaxSomething`. I think not because the non reverse order matches the scoped package name.
I was surprised that we still only have a single websocket.mod file, when we really should now have websocketJavax.mod and websocketJetty.mod... can you open another issue for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #3678
Change the naming convention for the WebSocket modules.
javax-websocket-client->websocket-javax-clientjavax-websocket-server->websocket-javax-serverjavax-websocket-common->websocket-javax-commonjavax-websocket-tests->websocket-javax-testsjetty-websocket-api->websocket-jetty-apijetty-websocket-client->websocket-jetty-clientjetty-websocket-server->websocket-jetty-serverjetty-websocket-common->websocket-jetty-commonjetty-websocket-tests->websocket-jetty-tests